[
https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=164360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164360
]
ASF GitHub Bot logged work on BEAM-4681:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/18 14:27
Start Date: 09/Nov/18 14:27
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6981:
[BEAM-4681] Add support for portable timers in Flink streaming mode
URL: https://github.com/apache/beam/pull/6981#discussion_r232266696
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -270,8 +294,22 @@ public void setKeyContextElement1(StreamRecord record)
throws Exception {
@Override
public void setCurrentKey(Object key) {
- throw new UnsupportedOperationException(
- "Current key for state backend can only be set by state requests from
SDK workers.");
+ if (stateful && usesTimers) {
Review comment:
Will simplify this.
> how does synchronizing just setCurrentKey help, how is the current key
then used (not synchronized?) when timers are present?
Good question. The synchronization is performed before calling
`setCurrentKey` at other places. The synchronize at this point is for the
underlying timer service HeapInternalTimerService which sets the current key
before firing the timer. There is a window for concurrent access. I will change
the implementation which will also get rid of the key Supplier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 164360)
Time Spent: 2.5h (was: 2h 20m)
> Integrate support for timers using the portability APIs into Flink
> ------------------------------------------------------------------
>
> Key: BEAM-4681
> URL: https://issues.apache.org/jira/browse/BEAM-4681
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Consider using the code produced in BEAM-4658 to support timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
