[
https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=165353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165353
]
ASF GitHub Bot logged work on BEAM-4681:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 10:32
Start Date: 13/Nov/18 10:32
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6981:
[BEAM-4681] Add support for portable timers in Flink streaming mode
URL: https://github.com/apache/beam/pull/6981#discussion_r232980105
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/ExecutableStageDoFnOperatorTest.java
##########
@@ -225,18 +229,22 @@ public String getId() {
@Override
public Map<String, FnDataReceiver<WindowedValue<?>>>
getInputReceivers() {
return ImmutableMap.of(
- "pCollectionId",
+ "input",
input -> {
/* Ignore input*/
});
}
@Override
public void close() throws Exception {
+ if (onceEmitted) {
Review comment:
Close is only called once per bundle but there are two bundles now due to
the watermark processing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165353)
Time Spent: 9h 50m (was: 9h 40m)
> Integrate support for timers using the portability APIs into Flink
> ------------------------------------------------------------------
>
> Key: BEAM-4681
> URL: https://issues.apache.org/jira/browse/BEAM-4681
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Consider using the code produced in BEAM-4658 to support timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
