[
https://issues.apache.org/jira/browse/BEAM-6058?focusedWorklogId=166194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166194
]
ASF GitHub Bot logged work on BEAM-6058:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 23:52
Start Date: 14/Nov/18 23:52
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7042:
[BEAM-6058] Publish gRPC 1.13.1 as a vendored dependency.
URL: https://github.com/apache/beam/pull/7042#discussion_r233665747
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/VendorJavaPlugin.groovy
##########
@@ -48,6 +49,10 @@ class VendorJavaPlugin implements Plugin<Project> {
project.ext.vendorJava = {
Review comment:
This is similar to how we've setup our other custom Gradle plugins (i.e.
`applyXYZNature(..)` methods which take a configuration object. It differs from
the convention used by most Gradle plugins, and I think the subtle difference
is confusing for people just starting to learn Gradle / Groovy.
This doc shows how to set up a conventional plugin:
https://docs.gradle.org/current/userguide/custom_plugins.html#sec:getting_input_from_the_build
The different would be to register the config object in `project.extensions`
and drop the explicit `vendorJava()` method:
```groovy
void apply(Project project) {
def extension = project.extensions.create('vendorJava',
VendorJavaPluginConfig)
// .. everything else from previous 'vendorJava' method inline here,
// referencing config from 'extension' variable
}
```
and then the usage looks slightly more conventional:
```groovy
apply plugin: org.apache.beam.gradle.VendorJavaPlugin
vendorJava {
// configuration block
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 166194)
Time Spent: 3h 50m (was: 3h 40m)
> Support flink config directory for flink runner.
> ------------------------------------------------
>
> Key: BEAM-6058
> URL: https://issues.apache.org/jira/browse/BEAM-6058
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Give user option to use flink configuration from a config directory.
> Earlier we only used jars to submit flink jobs which by default picks the
> cluster flink properties.
> Portability uses remote environment to submit flink job. In Remote
> execution, flink uses the client config instead of the cluster config. This
> require us to submit the custom flink properties via flink client.
> Suggestion is to read the flink config from a flink configuration folder and
> set them to the environment.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
