[ 
https://issues.apache.org/jira/browse/BEAM-6062?focusedWorklogId=166287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166287
 ]

ASF GitHub Bot logged work on BEAM-6062:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/18 06:15
            Start Date: 15/Nov/18 06:15
    Worklog Time Spent: 10m 
      Work Description: VaclavPlajt commented on a change in pull request 
#7037: [BEAM-6062] Spark runner do not show Beam metrics in Spark Web Interface
URL: https://github.com/apache/beam/pull/7037#discussion_r233722726
 
 

 ##########
 File path: 
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/SparkMetricsContainerStepMap.java
 ##########
 @@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.spark.metrics;
+
+import org.apache.beam.runners.core.metrics.MetricsContainerStepMap;
+
+/**
+ * Sole purpose of this class is to override {@link #toString()} of {@link 
MetricsContainerStepMap}
+ * in order to show meaningful metrics in Spark Web Interface.
+ */
+public class SparkMetricsContainerStepMap extends MetricsContainerStepMap {
+  private final transient SparkBeamMetric metricRenderer = new 
SparkBeamMetric();
 
 Review comment:
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 166287)
    Time Spent: 1h  (was: 50m)

> Spark runner do not show Beam metrics in Spark Web Interface
> ------------------------------------------------------------
>
>                 Key: BEAM-6062
>                 URL: https://issues.apache.org/jira/browse/BEAM-6062
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Vaclav Plajt
>            Assignee: Vaclav Plajt
>            Priority: Major
>         Attachments: Screen Shot 2018-11-07 at 13.15.28.png
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Spark's web interface do not show Beam metrics. There is only one 
> `Accumulable` "Beam.Metrics" with value acquired from java 
> `SparkMetricsContainerStepMap#toString()` which is default 
> `Object#toString()` implementation.
>  !Screen Shot 2018-11-07 at 13.15.28.png! 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to