[
https://issues.apache.org/jira/browse/BEAM-6049?focusedWorklogId=166501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166501
]
ASF GitHub Bot logged work on BEAM-6049:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/18 16:39
Start Date: 15/Nov/18 16:39
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7047:
[BEAM-6049] Add option to load job to GCS in Dataflow Runner
URL: https://github.com/apache/beam/pull/7047#discussion_r233905238
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
##########
@@ -141,6 +141,13 @@
void setDataflowWorkerJar(String dataflowWorkerJar);
+ @Description(
Review comment:
Will this eventually become the default behavior? Is there any reason to
support both?
If this will become default, I suggest using an
[experiment](https://github.com/apache/beam/blob/847f3e74f35bdd2163ed4fa00b31a8f6b3c0f673/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ExperimentalOptions.java#L37)
pipeline option rather than a named option. PipelineOptions become part of the
public API and are harder to drop later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166501)
Time Spent: 40m (was: 0.5h)
> Support Job / Graph upload to GCS in Dataflow Runner
> ----------------------------------------------------
>
> Key: BEAM-6049
> URL: https://issues.apache.org/jira/browse/BEAM-6049
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Andrea Foegler
> Assignee: Andrea Foegler
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add uploadGraph flag to support uploading the job / graph to GCS instead of
> embedding in the request. This change allows the API to support much larger
> graphs than the embedded format of CreateJob.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
