[ 
https://issues.apache.org/jira/browse/BEAM-6056?focusedWorklogId=166504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166504
 ]

ASF GitHub Bot logged work on BEAM-6056:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/18 16:42
            Start Date: 15/Nov/18 16:42
    Worklog Time Spent: 10m 
      Work Description: swegner commented on a change in pull request #7042: 
[BEAM-6056] Publish gRPC 1.13.1 as a vendored dependency.
URL: https://github.com/apache/beam/pull/7042#discussion_r233920717
 
 

 ##########
 File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/VendorJavaPlugin.groovy
 ##########
 @@ -48,6 +49,10 @@ class VendorJavaPlugin implements Plugin<Project> {
     project.ext.vendorJava = {
 
 Review comment:
   Bummer, I guess it's not as easy as I'd hoped. Thanks for looking into it.
   
   Yes, we can defer this. I'd like to clean up our common Gradle code to make 
it easier to understand, but no need to hold this PR to a higher standard than 
the status quo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 166504)
    Time Spent: 1h 10m  (was: 1h)

> Migrate gRPC to use vendoring library and vendoring format
> ----------------------------------------------------------
>
>                 Key: BEAM-6056
>                 URL: https://issues.apache.org/jira/browse/BEAM-6056
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Minor
>              Labels: portability
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This thread discusses the work: 
> https://lists.apache.org/thread.html/4c12db35b40a6d56e170cd6fc8bb0ac4c43a99aa3cb7dbae54176815@%3Cdev.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to