[ 
https://issues.apache.org/jira/browse/BEAM-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689947#comment-16689947
 ] 

Kenneth Knowles commented on BEAM-4439:
---------------------------------------

I like the general approach of changing the rule matching. Unfortunately, 
Calcite gives this error message, which is a little unclear. This error means 
that there was no way to apply the existing rules to create a non-FULL join.

> Do not convert a join that we cannot support
> --------------------------------------------
>
>                 Key: BEAM-4439
>                 URL: https://issues.apache.org/jira/browse/BEAM-4439
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Priority: Major
>              Labels: starter
>
> The BeamJoinRule matches all LogicalJoin operators. If we make it not match a 
> full join then Calcite should look for a different plan when it converts to 
> BeamLogicalConvention. That is a good step to make sure we can support things 
> and also force the logical optimizer to choose non-full joins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to