[
https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=167271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167271
]
ASF GitHub Bot logged work on BEAM-4681:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/18 22:13
Start Date: 18/Nov/18 22:13
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #7008:
[BEAM-4681] Add support for portable timers in Flink batch mode
URL: https://github.com/apache/beam/pull/7008#discussion_r234464396
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -927,22 +941,53 @@ public void setTimer(
/** @deprecated use {@link #setTimer(StateNamespace, String, Instant,
TimeDomain)}. */
@Deprecated
@Override
- public void setTimer(TimerData timerKey) {
- long time = timerKey.getTimestamp().getMillis();
- switch (timerKey.getDomain()) {
+ public void setTimer(TimerData timer) {
+ try {
+ getKeyedStateBackend().setCurrentKey(getCurrentKey());
+ String uniqueTimerId = getUniqueTimerId(timer);
Review comment:
The logic here also needs explanation. We first remove the pending timer but
then it is being put back in `registerTimer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167271)
Time Spent: 22.5h (was: 22h 20m)
> Integrate support for timers using the portability APIs into Flink
> ------------------------------------------------------------------
>
> Key: BEAM-4681
> URL: https://issues.apache.org/jira/browse/BEAM-4681
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.9.0
>
> Time Spent: 22.5h
> Remaining Estimate: 0h
>
> Consider using the code produced in BEAM-4658 to support timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
