[ 
https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=167403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167403
 ]

ASF GitHub Bot logged work on BEAM-4681:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Nov/18 14:31
            Start Date: 19/Nov/18 14:31
    Worklog Time Spent: 10m 
      Work Description: mxm commented on issue #7008: [BEAM-4681] Add support 
for portable timers in Flink batch mode 
URL: https://github.com/apache/beam/pull/7008#issuecomment-439911728
 
 
   > The commits belonging to BEAM-4681 are one unit of rollback
   
   I find the structure quite logical and it should enable more incremental 
rollback:
   
   - [BEAM-4681] Add support for portable timers in Flink batch mode
   Adds the batch support for timers
   
   - [BEAM-4681] Use CoderUtils to decode key
   Fixes an issue for Java PVR for streaming timers
   
   - [BEAM-4681] Enable Python ValidatesRunner timer tests
   Enables Python PVR
   
   - [BEAM-4681] Enable Java portable ValidatesRunner timer tests
   Enables Java PVR
   
   - [BEAM-4681] Simplify by replacing the two timer keys with a single one
   Refactoring which can be rolled back independently.
   
   But it is a personal preference and I'd also be fine with squashing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 167403)
    Time Spent: 24.5h  (was: 24h 20m)

> Integrate support for timers using the portability APIs into Flink
> ------------------------------------------------------------------
>
>                 Key: BEAM-4681
>                 URL: https://issues.apache.org/jira/browse/BEAM-4681
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-flink
>            Reporter: Luke Cwik
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability, portability-flink
>             Fix For: 2.9.0
>
>          Time Spent: 24.5h
>  Remaining Estimate: 0h
>
> Consider using the code produced in BEAM-4658 to support timers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to