[
https://issues.apache.org/jira/browse/BEAM-6096?focusedWorklogId=167632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167632
]
ASF GitHub Bot logged work on BEAM-6096:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 05:47
Start Date: 20/Nov/18 05:47
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #7085: [BEAM-6096]
illegal signature attribute when compiling with JDK 11
URL: https://github.com/apache/beam/pull/7085
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java
b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java
index 261a9794836..62d4cd2085b 100644
---
a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java
+++
b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java
@@ -120,12 +120,12 @@
/** An implementation which uses a {@link WindowFn} to merge windows. */
private static class MergingViaWindowFnRunner<T, W extends BoundedWindow>
extends WindowMergingFnRunner<T, W> {
- private final WindowFn<?, W> windowFn;
+ private final WindowFn<T, W> windowFn;
private final WindowFn<?, W>.MergeContext mergeContext;
private Collection<W> currentWindows;
private List<KV<W, Collection<W>>> mergedWindows;
- private MergingViaWindowFnRunner(WindowFn<?, W> windowFn) {
+ private MergingViaWindowFnRunner(WindowFn<T, W> windowFn) {
this.windowFn = windowFn;
this.mergedWindows = new ArrayList<>();
this.currentWindows = new ArrayList<>();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167632)
Time Spent: 1h 10m (was: 1h)
> illegal signature attribute when compiling with JDK 11
> ------------------------------------------------------
>
> Key: BEAM-6096
> URL: https://issues.apache.org/jira/browse/BEAM-6096
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Liam Miller-Cushon
> Assignee: Liam Miller-Cushon
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following code is invalid, and fails to compile with the JDK 11 javac:
> https://github.com/apache/beam/blob/1cbbc4d8755130f137e7d9ef4813e8d3b917cb70/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java#L132-L144
> The error is:
> ```
> error: error while generating class <anonymous
> org.apache.beam.fn.harness.WindowMergingFnRunner$MergingViaWindowFnRunner$1>
> (illegal signature attribute for type CAP#1)
> where CAP#1 is a fresh type-variable:
> CAP#1 extends Object from capture of ?
> ```
> The code was previously accepted by javac due to a bug, which has been fixed
> in JDK 11: https://bugs.openjdk.java.net/browse/JDK-8203436
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
