[
https://issues.apache.org/jira/browse/BEAM-6099?focusedWorklogId=167816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167816
]
ASF GitHub Bot logged work on BEAM-6099:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 16:41
Start Date: 20/Nov/18 16:41
Worklog Time Spent: 10m
Work Description: varundhussa commented on a change in pull request
#7088: [BEAM-6099] RedisIO support for PFADD operation
URL: https://github.com/apache/beam/pull/7088#discussion_r235080436
##########
File path:
sdks/java/io/redis/src/test/java/org/apache/beam/sdk/io/redis/RedisIOTest.java
##########
@@ -186,6 +186,25 @@ public void testWriteReadUsingRpushMethod() throws
Exception {
Assert.assertEquals(value + newValue, String.join("", values));
}
+ @Test
+ public void testWriteUsingHLLMethod() throws Exception {
+ String key = "key";
+ String values[] = {"1", "2"};
+
+ Jedis jedis =
+ RedisConnectionConfiguration.create(REDIS_HOST,
embeddedRedis.getPort()).connect();
+ jedis.pfadd(key, values[0]);
+
+ PCollection<KV<String, String>> write =
writePipeline.apply(Create.of(KV.of(key, values[1])));
Review comment:
That sounds good. Do you think adding random strings would make sense (would
require a tolerance error range in count), or a known list (eg: integer to
string). Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167816)
Time Spent: 1h (was: 50m)
> RedisIO support for PFADD operation
> -----------------------------------
>
> Key: BEAM-6099
> URL: https://issues.apache.org/jira/browse/BEAM-6099
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Affects Versions: 2.7.0
> Reporter: Varun Dhussa
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> HLL has multiple use cases such as analytics dashboards. It allows fast
> counts and an easy way to do unions over multiple sets while saving memory.
> I have created a small improvement to add the PFADD method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
