[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=167930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167930
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 19:22
Start Date: 20/Nov/18 19:22
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6925:
[BEAM-5315] Partially port IO: avro schema parsing and codecs
URL: https://github.com/apache/beam/pull/6925#discussion_r235137307
##########
File path: sdks/python/apache_beam/io/tfrecordio_test.py
##########
@@ -405,6 +405,9 @@ def test_process_auto(self):
assert_that(result, equal_to(['foo', 'bar']))
[email protected](sys.version_info[0] == 3,
Review comment:
The more tests we run on Jenkins in Python 3, the more Py3 regressions we
can capture.
If 1 out of 10 tests in the package is passing, it may be easier to enlist
one test in tox.ini, than add all tests in the package and skip 9 that are not
passing. If 9 out of 10 tests are passing, we can file a JIRA for a remaining
tests, if it's failing due to a self-contained failure and skip it, and add the
package.
If we think that the whole package will be fixed in ~a week, it may not be
worth the churn to add skipping instructions and add tests one-by-one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167930)
Time Spent: 6h 50m (was: 6h 40m)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
