[
https://issues.apache.org/jira/browse/BEAM-6084?focusedWorklogId=167974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167974
]
ASF GitHub Bot logged work on BEAM-6084:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 21:10
Start Date: 20/Nov/18 21:10
Worklog Time Spent: 10m
Work Description: swegner closed pull request #7074: [BEAM-6084] Fix
Dataflow runner task dependencies for container registration.
URL: https://github.com/apache/beam/pull/7074
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/google-cloud-dataflow-java/build.gradle
b/runners/google-cloud-dataflow-java/build.gradle
index c0b4ecad2183..ac8c1643fac5 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -173,6 +173,10 @@ task validatesRunnerLegacyWorkerTest(type: Test) {
}
}
+// Push docker images to a container registry for use within tests.
+// NB: Tasks which consume docker images from the registry should depend on
this
+// task directly ('dependsOn buildAndPushDockerContainer'). This ensures the
correct
+// task ordering such that the registry doesn't get cleaned up prior to task
completion.
task buildAndPushDockerContainer() {
dependsOn ":beam-sdks-java-container:docker"
finalizedBy 'cleanUpDockerImages'
@@ -245,15 +249,7 @@ task validatesRunnerPortabilityApi {
group = "Verification"
description "Validates Dataflow PortabilityApi runner"
dependsOn validatesRunnerFnApiWorkerTest
- // Clean up docker image
- doLast {
- exec {
- commandLine "docker", "rmi", "${dockerImageName}"
- }
- exec {
- commandLine "gcloud", "--quiet", "container", "images", "delete",
"${dockerImageName}"
- }
- }
+ dependsOn buildAndPushDockerContainer
}
task googleCloudPlatformLegacyWorkerIntegrationTest(type: Test) {
@@ -406,6 +402,7 @@ task postCommit {
task postCommitPortabilityApi {
group = "Verification"
description = "Various integration tests using the Dataflow FnApi runner."
+ dependsOn buildAndPushDockerContainer
dependsOn googleCloudPlatformFnApiWorkerIntegrationTest
dependsOn examplesJavaFnApiWorkerIntegrationTest
dependsOn coreSDKJavaFnApiWorkerIntegrationTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167974)
Time Spent: 1h 20m (was: 1h 10m)
> [beam_PostCommit_Java_ValidatesRunner_PortabilityApi_Dataflow_Gradle]
> [validatesRunnerPortabilityApi] No such image
> -------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6084
> URL: https://issues.apache.org/jira/browse/BEAM-6084
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Major
> Labels: currently-failing
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> _Use this form to file an issue for test failure:_
> * [Jenkins
> Job|https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_PortabilityApi_Dataflow_Gradle/96/]
> * [Gradle Build
> Scan|https://scans.gradle.com/s/gvxphs4s7d5cc/console-log?task=:beam-runners-google-cloud-dataflow-java:validatesRunnerPortabilityApi]
> * [Test source
> code|https://github.com/apache/beam/blob/5446d0cfd9a4fd701f3171ea8bda9ba8f44f4de4/runners/google-cloud-dataflow-java/build.gradle#L244]
> Initial investigation:
> Error message from Gradle scan:
> {{Error response from daemon: No such image:
> us.gcr.io/apache-beam-testing/java-postcommit-it/java:20181115000023}}
> I suspect this could be caused by my cleanup PR: [Share docker image name
> along with shared task|https://github.com/apache/beam/pull/6993]
> ----
> _After you've filled out the above details, please [assign the issue to an
> individual|https://beam.apache.org/contribute/postcommits-guides/index.html#find_specialist].
> Assignee should [treat test failures as
> high-priority|https://beam.apache.org/contribute/postcommits-policies/#assigned-failing-test],
> helping to fix the issue or find a more appropriate owner. See [Apache Beam
> Post-Commit
> Policies|https://beam.apache.org/contribute/postcommits-policies]._
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
