[
https://issues.apache.org/jira/browse/BEAM-6067?focusedWorklogId=167990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167990
]
ASF GitHub Bot logged work on BEAM-6067:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 21:46
Start Date: 20/Nov/18 21:46
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7081:
[BEAM-6067] In Python SDK, specify pipeline_proto_coder_id property in
non-Beam-standard CloudObject coders
URL: https://github.com/apache/beam/pull/7081#discussion_r235180783
##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -201,12 +201,17 @@ def as_cloud_object(self):
# We pass coders in the form "<coder_name>$<pickled_data>" to make the
# job description JSON more readable. Data before the $ is ignored by
# the worker.
- '@type': serialize_coder(self),
- 'component_encodings': list(
- component.as_cloud_object()
- for component in self._get_component_coders()
- ),
+ '@type':
+ serialize_coder(self),
+ 'component_encodings':
+ list(
Review comment:
One would write `[expression for value in iterable]` rather than
`list(expression for value in iterable)`. It's just something that struck me
reading through the code; no need to do the refactoring now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167990)
Time Spent: 2h (was: 1h 50m)
Remaining Estimate: 166h (was: 166h 10m)
> Dataflow runner should include portable pipeline coder id in CloudObject
> coder representation
> ---------------------------------------------------------------------------------------------
>
> Key: BEAM-6067
> URL: https://issues.apache.org/jira/browse/BEAM-6067
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Craig Chambers
> Assignee: Craig Chambers
> Priority: Major
> Original Estimate: 168h
> Time Spent: 2h
> Remaining Estimate: 166h
>
> When translating a BeamJava Coder into the DataflowRunner's CloudObject
> property map, include a property that specifies the id in the Beam model
> Pipeline coders map corresponding to that Coder. This will allow the
> DataflowRunner to reference the corresponding Beam coder in the FnAPI
> processing bundle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
