[
https://issues.apache.org/jira/browse/BEAM-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruoyun Huang resolved BEAM-5430.
--------------------------------
Resolution: Fixed
Fix Version/s: Not applicable
> Adjust implementation of CombineGroupedValues runner to use CombineFn.apply
> ---------------------------------------------------------------------------
>
> Key: BEAM-5430
> URL: https://issues.apache.org/jira/browse/BEAM-5430
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Daniel Oliveira
> Assignee: Ruoyun Huang
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the [implementation for the runner of
> Combine.GroupedValues|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java#L217]
> in the Java SDK it essentially re-implements what was already implemented in
> [CombineFn.apply|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java#L348].
> The implementation should instead just call CombineFn.apply for simplicity
> and code reuse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
