[
https://issues.apache.org/jira/browse/BEAM-5817?focusedWorklogId=168564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-168564
]
ASF GitHub Bot logged work on BEAM-5817:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/18 22:48
Start Date: 21/Nov/18 22:48
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#7114: [BEAM-5817] Add Nexmark SqlBoundedSideInputJoin
URL: https://github.com/apache/beam/pull/7114#discussion_r235559453
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -198,6 +195,9 @@ private boolean isSideInputJoin() {
if ((leftRows.isBounded() == PCollection.IsBounded.BOUNDED
&& rightRows.isBounded() == PCollection.IsBounded.BOUNDED)
|| (leftRows.isBounded() == UNBOUNDED && rightRows.isBounded() ==
UNBOUNDED)) {
+ verifySupportedTrigger(leftRows);
Review comment:
@akedin I think you added this - can you double check my thinking that it is
safe to move into here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 168564)
Time Spent: 7h 10m (was: 7h)
> Nexmark test of joining stream to files
> ---------------------------------------
>
> Key: BEAM-5817
> URL: https://issues.apache.org/jira/browse/BEAM-5817
> Project: Beam
> Issue Type: New Feature
> Components: examples-nexmark
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Nexmark is a convenient framework for testing the use case of large scale
> stream enrichment. One way is joining a stream to files, and it can be tested
> via any source that Nexmark supports.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
