[
https://issues.apache.org/jira/browse/BEAM-6110?focusedWorklogId=168569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-168569
]
ASF GitHub Bot logged work on BEAM-6110:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/18 22:55
Start Date: 21/Nov/18 22:55
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #7115:
[BEAM-6110] For SQL CoGBK-based join use EARLIEST output timestamp
URL: https://github.com/apache/beam/pull/7115
As an implementation detail of some SQL (equi-)joins, we perform a CoGBK.
The element timestamps from this are not super important, since the next GROUP
BY will have windowing that explicitly says which column to treat as a
timestamp. In other words, there is no need for a "timestamp combiner" to
decide what the output timestamp is since it is explicit. But we do need the
watermark to be held in an appropriate way. If we let it jump to the end of the
window and that happens to be the global window, then any downstream windowing
will be immediately droppable.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 168569)
Time Spent: 10m
Remaining Estimate: 0h
> Beam SQL join moves element timestamps to EOW sometimes, not always
> -------------------------------------------------------------------
>
> Key: BEAM-6110
> URL: https://issues.apache.org/jira/browse/BEAM-6110
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a CoGBK join is chosen, element timestamps move to EOW. When side input
> or lookup join is chosen, element timestamps are the timestamps from the main
> input element. In SQL sementics, these timestamps are not observable, as
> windowing is assigned at the next GROUP BY. So we just need the output to
> hold the watermark so that nothing becomes late or droppable, which implies
> we need to use MIN timestamp combiner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
