[
https://issues.apache.org/jira/browse/BEAM-6100?focusedWorklogId=169769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169769
]
ASF GitHub Bot logged work on BEAM-6100:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/18 13:17
Start Date: 27/Nov/18 13:17
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #7087:
[BEAM-6100] Collect metrics properly in Load tests
URL: https://github.com/apache/beam/pull/7087#discussion_r236657192
##########
File path:
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
##########
@@ -34,25 +35,29 @@
private static final org.slf4j.Logger LOG =
LoggerFactory.getLogger(MetricsReader.class);
- private enum DistributionType {
- MIN,
- MAX
- }
+ private static final int ERRONEOUS_METRIC_VALUE = -1;
private final PipelineResult result;
private final String namespace;
- public MetricsReader(PipelineResult result, String namespace) {
+ private final long now;
+
+ MetricsReader(PipelineResult result, String namespace, long now) {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169769)
Time Spent: 2h 10m (was: 2h)
> Runtime and total bytes metrics are not collected properly
> ----------------------------------------------------------
>
> Key: BEAM-6100
> URL: https://issues.apache.org/jira/browse/BEAM-6100
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, we collect time (distribution) and bytes (counter) metrics from
> one ParDo (called MetricsMonitor) that is put in pipelines in one,
> arbitrarily chosen place (usually "in the middle" of pipeline's graph. In
> some cases, invalid time (or total bytes count) is registered.
> Taking [this|https://github.com/apache/beam/pull/6987#discussion_r231976671]
> discussion into account, ideally, we'd like to:
> - collect runtime by recording time at the root and sink(s) of the pipeline
> - collect total bytes in a separate ParDo that allows deciding what byte
> amount do we actually want to collect (now it's coupled to the
> time-collecting Monitor which is inconvenient).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
