[
https://issues.apache.org/jira/browse/BEAM-5197?focusedWorklogId=169832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169832
]
ASF GitHub Bot logged work on BEAM-5197:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/18 15:51
Start Date: 27/Nov/18 15:51
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #7138:
[BEAM-5197] Increase test time progressing interval to avoid deadlock
URL: https://github.com/apache/beam/pull/7138#discussion_r236725438
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java
##########
@@ -307,7 +307,10 @@ public void close() {}
if (seenWatermark.get()) {
break;
}
- Thread.sleep(50);
+
+ // Consider that UnboundedSourceWrapper needs to acquire the
checkpoint lock below.
+ // So wait for enough time for that to happen.
+ Thread.sleep(200);
Review comment:
It is tricky because the processing time is expected to be advanced for the
event time timers to progress.
I've refactored the test to wait for the readers to finish; only then the
time is advanced and the final trigger executed. That avoids constantly holding
the lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169832)
Time Spent: 4h 10m (was: 4h)
> Flaky test: UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest
> ------------------------------------------------------------------------------
>
> Key: BEAM-5197
> URL: https://issues.apache.org/jira/browse/BEAM-5197
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Maximilian Michels
> Priority: Critical
> Labels: flake
> Fix For: 2.10.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService$1.compare(TestProcessingTimeService.java:52)
> at
> org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService$1.compare(TestProcessingTimeService.java:49)
> at java.util.PriorityQueue.siftUpUsingComparator(PriorityQueue.java:670)
> at java.util.PriorityQueue.siftUp(PriorityQueue.java:646)
> at java.util.PriorityQueue.offer(PriorityQueue.java:345)
> at
> org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService.registerTimer(TestProcessingTimeService.java:93)
> at
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.setNextWatermarkTimer(UnboundedSourceWrapper.java:452)
> at
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:225)
> at
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:87)
> at
> org.apache.beam.runners.flink.streaming.UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest.testValueEmission(UnboundedSourceWrapperTest.java:153)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
