[
https://issues.apache.org/jira/browse/BEAM-6114?focusedWorklogId=170032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170032
]
ASF GitHub Bot logged work on BEAM-6114:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/18 22:48
Start Date: 27/Nov/18 22:48
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #7121:
[BEAM-6114] Add isBounded() to BeamRelNode and BeamSqlTable, use for JOIN
URL: https://github.com/apache/beam/pull/7121#discussion_r236878578
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlTable.java
##########
@@ -31,6 +31,9 @@
/** create a {@code IO.write()} instance to write to target. */
POutput buildIOWriter(PCollection<Row> input);
+ /** Whether this table is bounded (known to be finite) or unbounded (may or
may not be finite). */
+ PCollection.IsBounded isBounded();
Review comment:
I think we probably want to ultimately get rid of BeamSqlTable and just use
raw PCollections
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170032)
Time Spent: 0.5h (was: 20m)
> SQL join selection should be done in planner, not in expansion to PTransform
> ----------------------------------------------------------------------------
>
> Key: BEAM-6114
> URL: https://issues.apache.org/jira/browse/BEAM-6114
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently Beam SQL joins all go through a single physical operator which has
> a single PTransform that does all join algorithms based on properties of its
> input PCollections as well as the relational algebra.
> A first step is to make the needed information part of the relational
> algebra, so it can choose a PTransform based on that, and the PTransforms can
> be simpler.
> Second step is to have separate (physical) relational operators for different
> join algorithms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
