[
https://issues.apache.org/jira/browse/BEAM-3661?focusedWorklogId=170808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170808
]
ASF GitHub Bot logged work on BEAM-3661:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 21:23
Start Date: 29/Nov/18 21:23
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #7125: [BEAM-3661] Port
TriggerExampleTest off DoFnTester
URL: https://github.com/apache/beam/pull/7125
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleTest.java
b/examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleTest.java
index ebbbe74e8796..c0911b48b38f 100644
---
a/examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleTest.java
+++
b/examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleTest.java
@@ -26,12 +26,12 @@
import java.util.Map;
import org.apache.beam.examples.cookbook.TriggerExample.ExtractFlowInfo;
import org.apache.beam.examples.cookbook.TriggerExample.TotalFlow;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.DoFn;
-import org.apache.beam.sdk.transforms.DoFnTester;
import org.apache.beam.sdk.transforms.ParDo;
import org.apache.beam.sdk.transforms.windowing.FixedWindows;
import org.apache.beam.sdk.transforms.windowing.Window;
@@ -40,7 +40,6 @@
import org.apache.beam.sdk.values.TimestampedValue;
import org.joda.time.Duration;
import org.joda.time.Instant;
-import org.junit.Assert;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -58,7 +57,8 @@
"01/01/2010
00:00:00,1108302,94,E,ML,36,100,29,0.0065,66,9,1,0.001,74.8,1,9,3,0.0028,71,1,9,"
+ "12,0.0099,67.4,1,9,13,0.0121,99.0,1,,,,,0,,,,,0,,,,,0,,,,,0",
"01/01/2010 00:00:00,"
- +
"1100333,5,N,FR,9,0,39,,,9,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,"
+ +
"1100333,5,N,FR,9,0,39,,,9,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,,0,,,,",
+ ""
};
private static final List<TimestampedValue<String>> TIME_STAMPED_INPUT =
@@ -104,16 +104,17 @@
@Rule public TestPipeline pipeline = TestPipeline.create();
@Test
- public void testExtractTotalFlow() throws Exception {
- DoFnTester<String, KV<String, Integer>> extractFlowInfow =
DoFnTester.of(new ExtractFlowInfo());
+ public void testExtractTotalFlow() {
+ PCollection<KV<String, Integer>> output =
+ pipeline
+
.apply(Create.of(Arrays.asList(INPUT)).withCoder(StringUtf8Coder.of()))
+ .apply(ParDo.of(new ExtractFlowInfo()));
- List<KV<String, Integer>> results = extractFlowInfow.processBundle(INPUT);
- Assert.assertEquals(1, results.size());
- Assert.assertEquals("94", results.get(0).getKey());
- Assert.assertEquals(Integer.valueOf(29), results.get(0).getValue());
+ KV<String, Integer> expectedOutput = KV.of("94", 29);
- List<KV<String, Integer>> output = extractFlowInfow.processBundle("");
- Assert.assertEquals(0, output.size());
+ PAssert.that(output).containsInAnyOrder(Arrays.asList(expectedOutput));
+
+ pipeline.run().waitUntilFinish();
}
@Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170808)
Time Spent: 1h (was: 50m)
> Port TriggerExampleTest off DoFnTester
> --------------------------------------
>
> Key: BEAM-3661
> URL: https://issues.apache.org/jira/browse/BEAM-3661
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Cade Markegard
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
