[
https://issues.apache.org/jira/browse/BEAM-4453?focusedWorklogId=171242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171242
]
ASF GitHub Bot logged work on BEAM-4453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/18 23:42
Start Date: 30/Nov/18 23:42
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #7147:
[BEAM-4453] Use constructors to generate schema POJOs
URL: https://github.com/apache/beam/pull/7147#discussion_r238034484
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/POJOUtils.java
##########
@@ -297,4 +365,56 @@ public ByteCodeAppender appender(final Target
implementationTarget) {
};
}
}
+
+ // Implements a method to construct an object.
+ static class ConstructInstruction implements Implementation {
+ private List<Field> fields;
Review comment:
`final`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171242)
Time Spent: 11.5h (was: 11h 20m)
> Provide automatic schema registration for POJOs
> -----------------------------------------------
>
> Key: BEAM-4453
> URL: https://issues.apache.org/jira/browse/BEAM-4453
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
