[
https://issues.apache.org/jira/browse/BEAM-5884?focusedWorklogId=171249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171249
]
ASF GitHub Bot logged work on BEAM-5884:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/18 00:02
Start Date: 01/Dec/18 00:02
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #7175:
[BEAM-5884] Move the nullable attribute onto FieldType.
URL: https://github.com/apache/beam/pull/7175#discussion_r238037409
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -410,14 +410,13 @@ public boolean isSupertypeOf(TypeName other) {
// Returns the type of this field.
public abstract TypeName getTypeName();
+ // Whether this type is nullable.
+ public abstract Boolean getNullable();
Review comment:
@akedin in fact there is such a method, but it's called withNullable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171249)
Time Spent: 4h 10m (was: 4h)
> Allow nested types have null value.
> -----------------------------------
>
> Key: BEAM-5884
> URL: https://issues.apache.org/jira/browse/BEAM-5884
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> We could allow arbitrary combination of nested types have null value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
