[ 
https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=171452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171452
 ]

ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/18 04:02
            Start Date: 03/Dec/18 04:02
    Worklog Time Spent: 10m 
      Work Description: tweise commented on issue #7183: [BEAM-6165] send 
metrics to Flink in portable Flink runner
URL: https://github.com/apache/beam/pull/7183#issuecomment-443582639
 
 
   @ryan-williams thanks for working on this. I will take a look in the next 
few days. I appreciate the detailed attention to peripheral code but want to 
point out that PRs changes should be limited to the stated purpose. Stray, 
unrelated changes cause unnecessary noise/distraction and can even lead to 
merge conflicts. It would be nice to make such changes in a separate PR. IMO 
there is no need to back them out in this case unless specifically noted, but 
please keep it in mind for future work. Thanks! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 171452)
    Time Spent: 1h 10m  (was: 1h)

> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
>                 Key: BEAM-6165
>                 URL: https://issues.apache.org/jira/browse/BEAM-6165
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>    Affects Versions: 2.8.0
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Major
>              Labels: metrics, portability, portability-flink
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runnerĀ in the Python SDK (and likely 
> Java soon), but the portable Flink runner doesn't pass them on to Flink, 
> which it should, so that users can see them in e.g. the Flink UI or via any 
> Flink metrics reporters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to