[
https://issues.apache.org/jira/browse/BEAM-6180?focusedWorklogId=172116&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172116
]
ASF GitHub Bot logged work on BEAM-6180:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 00:41
Start Date: 05/Dec/18 00:41
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7201:
[BEAM-6180] Make dataflow runner harness use IdGenerator from fnexecution
URL: https://github.com/apache/beam/pull/7201#discussion_r238888047
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/apiary/FixMultiOutputInfosOnParDoInstructionsTest.java
##########
@@ -78,7 +68,7 @@ public void testDefaultOutputHasDifferentIdsForEachMapTask()
{
@Test
public void testMissingTagsForMultipleOutputsThrows() {
FixMultiOutputInfosOnParDoInstructions function =
- new
FixMultiOutputInfosOnParDoInstructions(makeIdGeneratorStartingFrom(0));
+ new
FixMultiOutputInfosOnParDoInstructions(IdGenerators.decrementingLongs());
Review comment:
Won't this not work since decrementLongs may or may not start from zero?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172116)
Time Spent: 0.5h (was: 20m)
> Replace duplicated runner IdGenerator code with IdGenerator from shared lib
> ---------------------------------------------------------------------------
>
> Key: BEAM-6180
> URL: https://issues.apache.org/jira/browse/BEAM-6180
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
