[
https://issues.apache.org/jira/browse/BEAM-6167?focusedWorklogId=172301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172301
]
ASF GitHub Bot logged work on BEAM-6167:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 14:50
Start Date: 05/Dec/18 14:50
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7193:
[BEAM-6167] Add class ReadFromTextWithFilename (Python)
URL: https://github.com/apache/beam/pull/7193#discussion_r239095304
##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -527,6 +533,61 @@ def expand(self, pvalue):
return pvalue.pipeline | Read(self._source)
+class ReadFromTextWithFilename(PTransform):
Review comment:
Yes, I agree with that sentiment. The disadvantage I see here is that there
will have to be an active effort to keep the (non-trivial) set of arguments in
sync between the two from now on.
Another option would be to have a _ReadFromTextBase with two subclasses that
differ only in a class attribute set to either _TextSource or
_FilenameTextSource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172301)
Time Spent: 40m (was: 0.5h)
> Create a Class to read content of a file keeping track of the file path
> (python)
> --------------------------------------------------------------------------------
>
> Key: BEAM-6167
> URL: https://issues.apache.org/jira/browse/BEAM-6167
> Project: Beam
> Issue Type: Improvement
> Components: io-ideas
> Affects Versions: 2.8.0
> Reporter: Lorenzo Caggioni
> Assignee: Eugene Kirpichov
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add a class to read content of a file keeping track of the file path each
> element come from.
> This is an improvement of the current python/apache_beam/io/textio.py
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
