[
https://issues.apache.org/jira/browse/BEAM-6182?focusedWorklogId=172415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172415
]
ASF GitHub Bot logged work on BEAM-6182:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 17:45
Start Date: 05/Dec/18 17:45
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #7203:
[BEAM-6182] Disable conscrypt by default
URL: https://github.com/apache/beam/pull/7203#discussion_r239168968
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkerHarnessHelper.java
##########
@@ -57,18 +57,19 @@ public static DataflowWorkerHarnessOptions
initializeGlobalStateAndPipelineOptio
ExperimentContext ec = ExperimentContext.parseFrom(pipelineOptions);
- String experimentName =
Experiment.DisableConscryptSecurityProvider.getName();
- if (!ec.isEnabled(Experiment.DisableConscryptSecurityProvider)) {
+ String experimentName =
Experiment.EnableConscryptSecurityProvider.getName();
+ if (ec.isEnabled(Experiment.EnableConscryptSecurityProvider)) {
/* Enable fast SSL provider. */
LOG.info(
- "Dataflow runner uses conscrypt by default for SSL. To disable this
feature, "
- + "pass pipeline option --experiments={}",
+ "Dataflow runner is using conscrypt SSL. To disable this feature, "
+ + "remove the pipeline option --experiments={}",
experimentName);
Security.insertProviderAt(new OpenSSLProvider(), 1);
} else {
LOG.info(
Review comment:
I would like to keep it as an info since this is a change in behavior for
Dataflow runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172415)
Time Spent: 20m (was: 10m)
> Use of conscrypt SSL results in stuck workflows in Dataflow
> -----------------------------------------------------------
>
> Key: BEAM-6182
> URL: https://issues.apache.org/jira/browse/BEAM-6182
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Ahmet Altay
> Assignee: Tyler Akidau
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> An experimental flag is being added to disable it for now with an option to
> enable it per-workflow.
> Also related:
> https://issues.apache.org/jira/browse/BEAM-5747 - Upgrade conscrypt to its
> latest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
