[
https://issues.apache.org/jira/browse/BEAM-6159?focusedWorklogId=172751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172751
]
ASF GitHub Bot logged work on BEAM-6159:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 18:13
Start Date: 06/Dec/18 18:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7015:
[BEAM-6159] Migrate dataflow portable worker using shared library to process
bundle
URL: https://github.com/apache/beam/pull/7015#discussion_r239555944
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SingleEnvironmentInstanceJobBundleFactory.java
##########
@@ -66,15 +68,21 @@ public static JobBundleFactory create(
private final ConcurrentMap<Environment, RemoteEnvironment> environments =
new ConcurrentHashMap<>();
- private final IdGenerator idGenerator = IdGenerators.incrementingLongs();
+ private final IdGenerator idGenerator;
private SingleEnvironmentInstanceJobBundleFactory(
Review comment:
nit: in a follow-up PR make all callers explicitly pass in their idgenerator
instead of allowing idgenerator be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172751)
Time Spent: 1h 20m (was: 1h 10m)
> Dataflow portable runner harness should use ExecutableStage to process bundle
> -----------------------------------------------------------------------------
>
> Key: BEAM-6159
> URL: https://issues.apache.org/jira/browse/BEAM-6159
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
