[ 
https://issues.apache.org/jira/browse/BEAM-6138?focusedWorklogId=173098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173098
 ]

ASF GitHub Bot logged work on BEAM-6138:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Dec/18 22:59
            Start Date: 07/Dec/18 22:59
    Worklog Time Spent: 10m 
      Work Description: Ardagan commented on a change in pull request #6799: 
[BEAM-6138] Add User Counter Metric Support to Java SDK
URL: https://github.com/apache/beam/pull/6799#discussion_r239969659
 
 

 ##########
 File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
 ##########
 @@ -137,6 +143,21 @@ public ProcessBundleHandler(
         new 
UnknownPTransformRunnerFactory(urnToPTransformRunnerFactoryMap.keySet());
   }
 
+  private void extractMonitoringInfosToResponse(
 
 Review comment:
   This method should build a list of MonitoringInfos and caller should set 
MonitoringInfos to response.
   Doing this will simplify reading code greatly and prevent further complexity 
growth.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 173098)
    Time Spent: 2h 50m  (was: 2h 40m)

> Add User Metric Support to Java SDK
> -----------------------------------
>
>                 Key: BEAM-6138
>                 URL: https://issues.apache.org/jira/browse/BEAM-6138
>             Project: Beam
>          Issue Type: New Feature
>          Components: java-fn-execution
>            Reporter: Alex Amato
>            Assignee: Alex Amato
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to