[
https://issues.apache.org/jira/browse/BEAM-6176?focusedWorklogId=173133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173133
]
ASF GitHub Bot logged work on BEAM-6176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/18 01:28
Start Date: 08/Dec/18 01:28
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #7196:
[BEAM-6176] Support IPv6 addresses for Flink master url
URL: https://github.com/apache/beam/pull/7196#discussion_r239987306
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkExecutionEnvironmentsTest.java
##########
@@ -279,33 +279,45 @@ public void shouldDetectMalformedPortStreaming() {
options.setFlinkMaster("host:p0rt");
expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("Provided port is malformed");
+ expectedException.expectMessage("Unparseable port number");
FlinkExecutionEnvironments.createStreamExecutionEnvironment(options,
Collections.emptyList());
}
@Test
- public void shouldFailOnEmptyPortBatch() {
+ public void shouldSupportIPv6Batch() {
FlinkPipelineOptions options =
PipelineOptionsFactory.as(FlinkPipelineOptions.class);
options.setRunner(FlinkRunner.class);
- options.setFlinkMaster("host:");
Review comment:
That makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 173133)
Time Spent: 50m (was: 40m)
> Flink Runner's master url does not support IPv6 addresses
> ---------------------------------------------------------
>
> Key: BEAM-6176
> URL: https://issues.apache.org/jira/browse/BEAM-6176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The port parsing logic does not support IPv6.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
