[
https://issues.apache.org/jira/browse/BEAM-6021?focusedWorklogId=173517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173517
]
ASF GitHub Bot logged work on BEAM-6021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/18 11:05
Start Date: 10/Dec/18 11:05
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #6998:
[BEAM-6021] Registered more internal classes for kryo serialization
URL: https://github.com/apache/beam/pull/6998#discussion_r240168072
##########
File path:
runners/spark/src/test/java/org/apache/beam/runners/spark/coders/BeamSparkRunnerRegistratorTest.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.spark.coders;
+
+import static org.junit.Assert.assertTrue;
+
+import org.apache.beam.runners.spark.util.ByteArray;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+import org.apache.spark.serializer.KryoSerializer;
+import org.apache.spark.serializer.Serializer;
+import org.junit.Test;
+import scala.reflect.ClassTag;
+import scala.reflect.ClassTag$;
+
+/** Testing of beam registrar. */
+public class BeamSparkRunnerRegistratorTest {
Review comment:
Probably worth to add an extra test that asserts that the Registrator is not
called by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 173517)
Time Spent: 2h 40m (was: 2.5h)
> Registered more internal classes for kryo serialization
> -------------------------------------------------------
>
> Key: BEAM-6021
> URL: https://issues.apache.org/jira/browse/BEAM-6021
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Affects Versions: 2.8.0
> Reporter: Marek Simunek
> Assignee: Marek Simunek
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> When using {{KryoSerializer}} we could improve serialization performance with
> registering internal classes used in SparkRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
