[
https://issues.apache.org/jira/browse/BEAM-5058?focusedWorklogId=174381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-174381
]
ASF GitHub Bot logged work on BEAM-5058:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/18 01:49
Start Date: 12/Dec/18 01:49
Worklog Time Spent: 10m
Work Description: tweise closed pull request #7246: [BEAM-5058] remove
unused envdir parameter
URL: https://github.com/apache/beam/pull/7246
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/build.gradle b/sdks/python/build.gradle
index 4b0036824f37..a17b032a0a48 100644
--- a/sdks/python/build.gradle
+++ b/sdks/python/build.gradle
@@ -112,8 +112,8 @@ task preCommit() {
task portablePreCommit() {
dependsOn ':beam-runners-flink_2.11-job-server-container:docker'
dependsOn ':beam-sdks-python-container:docker'
- dependsOn portableWordCountTask('portableWordCountBatch', false, envdir)
- dependsOn portableWordCountTask('portableWordCountStreaming', true, envdir)
+ dependsOn portableWordCountTask('portableWordCountBatch', false)
+ dependsOn portableWordCountTask('portableWordCountStreaming', true)
}
@@ -207,10 +207,10 @@ task directRunnerIT(dependsOn: 'installGcpTest') {
// ./gradlew :beam-sdks-python:portableWordCount
-PjobEndpoint=localhost:8099
//
task portableWordCount {
- dependsOn portableWordCountTask('portableWordCountExample',
project.hasProperty("streaming"), envdir)
+ dependsOn portableWordCountTask('portableWordCountExample',
project.hasProperty("streaming"))
}
-def portableWordCountTask(name, streaming, envdir) {
+def portableWordCountTask(name, streaming) {
tasks.create(name) {
dependsOn = ['installGcpTest']
mustRunAfter = [':beam-runners-flink_2.11-job-server-container:docker',
':beam-sdks-python-container:docker']
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 174381)
Time Spent: 6h 50m (was: 6h 40m)
> Python precommits should run E2E tests
> --------------------------------------
>
> Key: BEAM-5058
> URL: https://issues.apache.org/jira/browse/BEAM-5058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: Udi Meiri
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> According to [https://beam.apache.org/contribute/testing/] (which I'm working
> on), end-to-end tests should be run in precommit on each combination of
> \{batch, streaming}x\{SDK language}x\{supported runner}.
> At least 2 tests need to be added to Python's precommit: wordcount and
> wordcount_streaming on Dataflow, and possibly on other supported runners
> (direct runner and new runners plz).
> These tests should be configured to run from a Gradle sub-project, so that
> they're run in parallel to the unit tests.
> Example that parallelizes Java precommit integration tests:
> [https://github.com/apache/beam/pull/5731]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
