[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=174733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-174733
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/18 02:21
Start Date: 13/Dec/18 02:21
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #7050:
[BEAM-5959] Reimplement GCS copies with rewrites.
URL: https://github.com/apache/beam/pull/7050#discussion_r241253203
##########
File path: sdks/python/apache_beam/io/gcp/gcsio.py
##########
@@ -186,6 +187,15 @@ def __init__(self, storage_client=None):
# storage_client is None.
if storage_client is not None:
self.client = storage_client
+ self._rewrite_cb = None
+
+ def _set_rewrite_response_callback(self, callback):
Review comment:
This callback is used by the integration test to verify that a multi-part
rewrite has occurred. Mocking out the storage client defeats the purpose of
doing an integration test. I tried mock's wraps= kwargs to patch
StorageV1.ObjectsService, but I didn't get very far and I'm not sure it's worth
the effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 174733)
Time Spent: 5h (was: 4h 50m)
> Add Cloud KMS support to GCS copies
> -----------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
