[
https://issues.apache.org/jira/browse/BEAM-6225?focusedWorklogId=175045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-175045
]
ASF GitHub Bot logged work on BEAM-6225:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/18 20:52
Start Date: 13/Dec/18 20:52
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7271:
[BEAM-6225] Setup Jenkins Job to Run VR with ExecutableStage
URL: https://github.com/apache/beam/pull/7271#discussion_r241499082
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -241,6 +241,38 @@ task validatesRunnerFnApiWorkerTest(type: Test) {
}
}
+task validatesRunnerFnApiWorkerExecutableStageTest(type: Test) {
+ group = "Verification"
+ dependsOn
":beam-runners-google-cloud-dataflow-java-fn-api-worker:shadowJar"
+ dependsOn buildAndPushDockerContainer
+ fnApiPipelineOptions.remove(2)
Review comment:
This seems brittle; adding or reordering the above `fnApiPipelineOptions`
array would break this in non-obvious ways.
Is there a way to phrase this logic to make it less brittle? i.e. search the
array for the `--experiments` prefix and remove it directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 175045)
Time Spent: 50m (was: 40m)
> Setup Jenkins VR job for new bundle processing code
> ---------------------------------------------------
>
> Key: BEAM-6225
> URL: https://issues.apache.org/jira/browse/BEAM-6225
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
