[
https://issues.apache.org/jira/browse/BEAM-4454?focusedWorklogId=175057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-175057
]
ASF GitHub Bot logged work on BEAM-4454:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/18 21:21
Start Date: 13/Dec/18 21:21
Worklog Time Spent: 10m
Work Description: kanterov commented on a change in pull request #7267:
[BEAM-4454] Support Avro POJO objects
URL: https://github.com/apache/beam/pull/7267#discussion_r241543456
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroUserTypeCreatorFactory.java
##########
@@ -17,13 +17,12 @@
*/
package org.apache.beam.sdk.schemas;
-import org.apache.avro.specific.SpecificRecord;
import org.apache.beam.sdk.schemas.utils.AvroUtils;
-/** A {@link UserTypeCreatorFactory} for AVRO-generated specific records. */
-public class AvroSpecificRecordUserTypeCreatorFactory implements
UserTypeCreatorFactory {
+/** A {@link UserTypeCreatorFactory} for AVRO-generated specific records and
POJOs. */
+public class AvroUserTypeCreatorFactory implements UserTypeCreatorFactory {
@Override
public SchemaUserTypeCreator create(Class<?> clazz, Schema schema) {
- return AvroUtils.getCreator((Class<? extends SpecificRecord>) clazz,
schema);
+ return AvroUtils.getCreator(clazz, schema);
Review comment:
I would propose to inline `AvroUtils.getCreator`, unless there is a reason
to make it reusable. The same in `AvroTypeInformationFactory` and
`AvroClassGetterFactory`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 175057)
Time Spent: 10.5h (was: 10h 20m)
> Provide automatic schema registration for AVROs
> -----------------------------------------------
>
> Key: BEAM-4454
> URL: https://issues.apache.org/jira/browse/BEAM-4454
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Need to make sure this is a compatible change
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
