[
https://issues.apache.org/jira/browse/BEAM-5723?focusedWorklogId=175130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-175130
]
ASF GitHub Bot logged work on BEAM-5723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/18 01:25
Start Date: 14/Dec/18 01:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #7237: [BEAM-5723]
Changed shadow plugin configuration to avoid relocating g…
URL: https://github.com/apache/beam/pull/7237#issuecomment-447180932
I am just starting to review, but I want to get some principles out
beforehand:
1. The shaded path should absolutely never be used. It is derived from the
module name just to make it unique. The reason we shade is as a way to isolate
"implementation detail" dependencies. If this ends up on an API surface that is
a bug. We had some tests for this, but they have rotted.
2. We work pretty hard to avoid Guava on the API surface, since the risk of
diamond dependency conflicts is very high.
3. It is OK for an IO to have its own esoteric dependencies - including
Guava - if the thing it is connecting to requires it. So if it is _Cassandra_
that requires Gauva on the API surface, then it can be included in the deps.
4. For those situations where Beam wants to use Guava internally, we are
(slowly) moving to depend on `beam-vendored-guava-20_0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 175130)
Time Spent: 1h 40m (was: 1.5h)
> CassandraIO is broken because of use of bad relocation of guava
> ---------------------------------------------------------------
>
> Key: BEAM-5723
> URL: https://issues.apache.org/jira/browse/BEAM-5723
> Project: Beam
> Issue Type: Bug
> Components: io-java-cassandra
> Affects Versions: 2.5.0, 2.6.0, 2.7.0
> Reporter: Arun sethia
> Assignee: João Cabrita
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> While using apache beam to run dataflow job to read data from BigQuery and
> Store/Write to Cassandra with following libaries:
> # beam-sdks-java-io-cassandra - 2.6.0
> # beam-sdks-java-io-jdbc - 2.6.0
> # beam-sdks-java-io-google-cloud-platform - 2.6.0
> # beam-sdks-java-core - 2.6.0
> # google-cloud-dataflow-java-sdk-all - 2.5.0
> # google-api-client -1.25.0
>
> I am getting following error at the time insert/save data to Cassandra.
> {code:java}
> [error] (run-main-0) org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:332)
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:302)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:197)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:64)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:313)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:299){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
