[
https://issues.apache.org/jira/browse/BEAM-6056?focusedWorklogId=177100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177100
]
ASF GitHub Bot logged work on BEAM-6056:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 17:43
Start Date: 19/Dec/18 17:43
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7255:
WIP [BEAM-6056] Rename v1_13_1 to v1p13p1.
URL: https://github.com/apache/beam/pull/7255#discussion_r243012197
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring.groovy
##########
@@ -72,7 +72,7 @@ class GrpcVendoring {
// those libraries may provide. The
'validateShadedJarDoesntLeakNonOrgApacheBeamClasses'
// ensures that there are no classes outside of the 'org.apache.beam'
namespace.
- String prefix = "org.apache.beam.vendor.grpc.v1_13_1";
+ String prefix = "org.apache.beam.vendor.grpc.v1p13p1";
Review comment:
It seems this prefix isn't currently used.. that looks suspicious
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177100)
Time Spent: 3h 40m (was: 3.5h)
> Migrate gRPC to use vendoring library and vendoring format
> ----------------------------------------------------------
>
> Key: BEAM-6056
> URL: https://issues.apache.org/jira/browse/BEAM-6056
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Luke Cwik
> Assignee: Kenneth Knowles
> Priority: Minor
> Labels: portability
> Fix For: 2.10.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> This thread discusses the work:
> https://lists.apache.org/thread.html/4c12db35b40a6d56e170cd6fc8bb0ac4c43a99aa3cb7dbae54176815@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
