[
https://issues.apache.org/jira/browse/BEAM-6270?focusedWorklogId=177186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177186
]
ASF GitHub Bot logged work on BEAM-6270:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 21:17
Start Date: 19/Dec/18 21:17
Worklog Time Spent: 10m
Work Description: swegner closed pull request #7320: [BEAM-6270] Fix
documentation for PCollection Type in XmlIO example
URL: https://github.com/apache/beam/pull/7320
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlIO.java
b/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlIO.java
index 6b4976c544ce..73d21da4af3e 100644
--- a/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlIO.java
+++ b/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlIO.java
@@ -85,7 +85,7 @@
* <p>Example:
*
* <pre>{@code
- * PCollection<String> output = p.apply(XmlIO.<Record>read()
+ * PCollection<Record> output = p.apply(XmlIO.<Record>read()
* .from(file.toPath().toString())
* .withRootElement("root")
* .withRecordElement("record")
@@ -126,7 +126,7 @@
* Duration.standardSeconds(30),
afterTimeSinceNewOutput(Duration.standardMinutes(5))))
* .apply(FileIO.readMatches().withCompression(GZIP));
*
- * PCollection<String> output = files.apply(XmlIO.<Record>readFiles()
+ * PCollection<Record> output = files.apply(XmlIO.<Record>readFiles()
* .withRootElement("root")
* .withRecordElement("record")
* .withRecordClass(Record.class));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177186)
Time Spent: 40m (was: 0.5h)
> XmlIO documentation example should return Pcollection of Record Class not
> String
> --------------------------------------------------------------------------------
>
> Key: BEAM-6270
> URL: https://issues.apache.org/jira/browse/BEAM-6270
> Project: Beam
> Issue Type: Bug
> Components: io-java-files
> Reporter: Theodore Siu
> Assignee: Eugene Kirpichov
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the example listed for XmlIO.Read located at
> [https://github.com/apache/beam/blob/master/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlIO.java]
> (line 88 and also at line 129) returns a PCollection of Strings instead of a
> PCollection of the record class which is a Jaxb annotated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
