[
https://issues.apache.org/jira/browse/BEAM-4762?focusedWorklogId=177450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177450
]
ASF GitHub Bot logged work on BEAM-4762:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/18 12:01
Start Date: 20/Dec/18 12:01
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #6808:
[BEAM-4762] Add Gearpump Nexmark PostCommit scripts
URL: https://github.com/apache/beam/pull/6808#discussion_r243247505
##########
File path: .test-infra/jenkins/job_PostCommit_Java_Nexmark_Gearpump.groovy
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import NexmarkBigqueryProperties
+import NexmarkBuilder as Nexmark
+import NoPhraseTriggeringPostCommitBuilder
+import PhraseTriggeringPostCommitBuilder
+
+// This job runs the suite of Nexmark tests against the Gearpump runner.
+NoPhraseTriggeringPostCommitBuilder.postCommitJob('beam_PostCommit_Java_Nexmark_Gearpump',
+ 'Gearpump Runner Nexmark Tests', this) {
+ description('Runs the Nexmark suite on the Gearpump runner.')
+
+ // Set common parameters.
+ commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 240)
+
+ // Gradle goals for this job.
+ steps {
Review comment:
I think you can use `NexmarkBuilder` here too but change the
`TriggeringContext` to `POST_COMMIT`. The reason I didn't refactor other
Nexmark post commit jobs this way is that I didn't want to touch them and break
anything (at that time those were broken temporarily). My fault that I didn't
refactor this further when the Nexmark jobs were fixed. I created an issue for
this: https://issues.apache.org/jira/browse/BEAM-6278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177450)
Time Spent: 5h 40m (was: 5.5h)
> Add postCommit scripts and perfkit dashboards for nexmark on Gearpump runner
> ----------------------------------------------------------------------------
>
> Key: BEAM-4762
> URL: https://issues.apache.org/jira/browse/BEAM-4762
> Project: Beam
> Issue Type: Test
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Manu Zhang
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
