[
https://issues.apache.org/jira/browse/BEAM-6276?focusedWorklogId=178277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178277
]
ASF GitHub Bot logged work on BEAM-6276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/18 17:06
Start Date: 22/Dec/18 17:06
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #7331: [BEAM-6276] Fix
performance regression.
URL: https://github.com/apache/beam/pull/7331#issuecomment-449584462
FYI the directrunner graphs show marked improvement after this PR was
merged.
On Fri, Dec 21, 2018 at 9:11 AM Gleb Kanterov <[email protected]>
wrote:
> @kanterov <https://github.com/kanterov> where do you see apply() doing
> reflection per row?
>
> @reuvenlax <https://github.com/reuvenlax> I did a rough benchmark (to be
> verified and investigated) of using JavaBeanSchema vs. hand-crafted code:
>
> Benchmark Mode Cnt Score Error Units
>
> FromRowBenchmark.javaBeanSchema thrpt 6 0.007 ± 0.001 ops/ns
>
> FromRowBenchmark.javaCode thrpt 6 0.071 ± 0.017 ops/ns
>
>
> I would investigate and get back to you.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/7331#issuecomment-449444610>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1Xqo8HgpUrH2zbNOfSWD5RfphxACks5u7RYvgaJpZM4ZbvGg>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178277)
Time Spent: 2h (was: 1h 50m)
> Performance regression caused by extra calls to TypeDescriptor.getRawType
> -------------------------------------------------------------------------
>
> Key: BEAM-6276
> URL: https://issues.apache.org/jira/browse/BEAM-6276
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
