[
https://issues.apache.org/jira/browse/BEAM-5723?focusedWorklogId=178630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178630
]
ASF GitHub Bot logged work on BEAM-5723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Dec/18 08:58
Start Date: 26/Dec/18 08:58
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7237: [BEAM-5723]
Changed shadow plugin configuration to avoid relocating g…
URL: https://github.com/apache/beam/pull/7237#discussion_r243964674
##########
File path: sdks/java/io/cassandra/build.gradle
##########
@@ -17,7 +17,24 @@
*/
apply plugin: org.apache.beam.gradle.BeamModulePlugin
-applyJavaNature()
+applyJavaNature(shadowClosure: {
Review comment:
This is the best approach but we probably need to document in the IO that
this may leak guava 19 (from Cassandra's driver) and this can have unintended
consequences no? at least until all Beam's base modules use the vendored
version as a dependency too. or am I misreading @kennknowles?
Side discussion (not related to the Cassandra case): I was taking a look at
the use of vendored versions and could not find many docs/examples I suppose
that this is because this is in progress? Anyway I can help there. I just found
that many core modules `beam-runners-core-java,
beam-runners-core-construction-java, beam-model-fn-execution, etc.` are still
repackaging guava its own way, but more critical that
`beam-runners-direct-java` repackages guava 5 times because of its dependencies
which is particularly bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178630)
Time Spent: 4h (was: 3h 50m)
> CassandraIO is broken because of use of bad relocation of guava
> ---------------------------------------------------------------
>
> Key: BEAM-5723
> URL: https://issues.apache.org/jira/browse/BEAM-5723
> Project: Beam
> Issue Type: Bug
> Components: io-java-cassandra
> Affects Versions: 2.5.0, 2.6.0, 2.7.0
> Reporter: Arun sethia
> Assignee: João Cabrita
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> While using apache beam to run dataflow job to read data from BigQuery and
> Store/Write to Cassandra with following libaries:
> # beam-sdks-java-io-cassandra - 2.6.0
> # beam-sdks-java-io-jdbc - 2.6.0
> # beam-sdks-java-io-google-cloud-platform - 2.6.0
> # beam-sdks-java-core - 2.6.0
> # google-cloud-dataflow-java-sdk-all - 2.5.0
> # google-api-client -1.25.0
>
> I am getting following error at the time insert/save data to Cassandra.
> {code:java}
> [error] (run-main-0) org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:332)
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:302)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:197)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:64)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:313)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:299){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
