[
https://issues.apache.org/jira/browse/BEAM-6231?focusedWorklogId=179197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179197
]
ASF GitHub Bot logged work on BEAM-6231:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Dec/18 19:20
Start Date: 27/Dec/18 19:20
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #7356: [BEAM-6231]
Make Dataflow runner harness work with FixedWindow
URL: https://github.com/apache/beam/pull/7356#discussion_r244211729
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java
##########
@@ -191,6 +195,37 @@ public Node apply(MutableNetwork<Node, Edge> input) {
Iterables.filter(input.nodes(), InstructionOutputNode.class)) {
InstructionOutput instructionOutput = node.getInstructionOutput();
+ // If this is the input PCollection or the output PCollection for an
ExecutableStage, it's
Review comment:
From my understanding, the input and output PCollection go through fnapi
data channel between runner harness and sdk harness. Taking sending value from
runner harness as an example, it needs a coder(```element coder``` + ```window
coder```) to encode value then send it to sdk harness. The ```element coder```
is got from component by ```coderId```, and ```window coder``` is got from
WindowingStrategy by ```windowingStrategyId```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 179197)
Time Spent: 1.5h (was: 1h 20m)
> Triage test failures introduced by use_executable_stage_bundle_execution
> ------------------------------------------------------------------------
>
> Key: BEAM-6231
> URL: https://issues.apache.org/jira/browse/BEAM-6231
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
