[
https://issues.apache.org/jira/browse/BEAM-6233?focusedWorklogId=179210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179210
]
ASF GitHub Bot logged work on BEAM-6233:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Dec/18 19:59
Start Date: 27/Dec/18 19:59
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #7330: [BEAM-6233]:
Add initial user timer support in Dataflow for batch pipelines
URL: https://github.com/apache/beam/pull/7330#discussion_r244215721
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/RegisterNodeFunction.java
##########
@@ -340,6 +335,53 @@ public Node apply(MutableNetwork<Node, Edge> input) {
}
ptransformIdToPCollectionViews.put(ptransformId,
pcollectionViews.build());
+ // This gets the main input pcollection id for this PTransform.
This will use the id to
+ // retrieve the Key coder to give to the timer.
+ String mainInputKeyCoderId = "";
+ for (Node predecessorOutput : input.predecessors(node)) {
+ String mainInputPCollectionId =
nodesToPCollections.get(predecessorOutput);
Review comment:
Obtaining mainInputPCollectionId is the only step you need to do inside loop.
Extracting mainInputKeyCoderId given mainInputPCollectionId can be done
outside of loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 179210)
Time Spent: 1h 50m (was: 1h 40m)
> Make bundle execution with ExecutableStage support timer/states
> ---------------------------------------------------------------
>
> Key: BEAM-6233
> URL: https://issues.apache.org/jira/browse/BEAM-6233
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
