[
https://issues.apache.org/jira/browse/BEAM-5112?focusedWorklogId=179562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179562
]
ASF GitHub Bot logged work on BEAM-5112:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/18 20:45
Start Date: 28/Dec/18 20:45
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #6417: [BEAM-5112]
Use Calcite codegen to implement BeamCalcRel
URL: https://github.com/apache/beam/pull/6417#discussion_r244404540
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
##########
@@ -1047,7 +1046,9 @@ public void testTruncate() {
@SqlOperatorTest(name = "RAND", kind = "OTHER_FUNCTION")
public void testRand() {
ExpressionChecker checker =
- new ExpressionChecker().addExpr("RAND(c_integer)", new
Random(INTEGER_VALUE).nextDouble());
+ new ExpressionChecker()
+ .addExpr(
+ "RAND(c_integer)", new Random(INTEGER_VALUE ^ (INTEGER_VALUE
<< 16)).nextDouble());
Review comment:
This is actually testing Calcite now. I'm guessing this behavior is
determined by the SQL standard, but we probably don't do the right thing if
there is more than one thread/worker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 179562)
Time Spent: 3h 20m (was: 3h 10m)
> Investigate if Calcite can generate functions that we need
> ----------------------------------------------------------
>
> Key: BEAM-5112
> URL: https://issues.apache.org/jira/browse/BEAM-5112
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
