[
https://issues.apache.org/jira/browse/BEAM-4725?focusedWorklogId=179586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179586
]
ASF GitHub Bot logged work on BEAM-4725:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/18 22:26
Start Date: 28/Dec/18 22:26
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #7357: [BEAM-4725] Use
unsafe to avoid small allocations to the heap.
URL: https://github.com/apache/beam/pull/7357#issuecomment-450437077
You're not wrong. The problem is the indirection through the interfaces.
*anything* could be in there and it won't be known necessarily at runtime. At
least, it won't be known at package compile time, since it's a subsequent
package that would use the function.
The only way I can see around it, would be to do whole program optimization,
and check the status of all parameters for all implementations of a given
interface method. If nothing ever escapes, then the compiler can smooth things
over. However, then it would still fail if one of the io.Read methods do cause
their parameters to escape, and we're back where we started.
As it stands, I don't think Go currently does a whole program optimization
pass. Maybe someday though.
You can learn more about some of the flaws in the escape analyzer (at least
as of Go1.10) here:
https://www.ardanlabs.com/blog/2018/01/escape-analysis-flaws.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 179586)
Time Spent: 50m (was: 40m)
> Reduce framework overhead in Go SDK
> -----------------------------------
>
> Key: BEAM-4725
> URL: https://issues.apache.org/jira/browse/BEAM-4725
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The Go SDK produces correct results, but it also does redundant
> recomputations, or allocations. This Jira is to track performance
> improvements along any per-element path, where that overhead could be
> significant.
> Contributions should include at least one benchmark with before and after
> values to demonstrate the value of the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
