[
https://issues.apache.org/jira/browse/BEAM-6030?focusedWorklogId=180765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180765
]
ASF GitHub Bot logged work on BEAM-6030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/19 16:00
Start Date: 03/Jan/19 16:00
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #7400: [BEAM-6030] Split
metrics related options out of PipelineOptions
URL: https://github.com/apache/beam/pull/7400#issuecomment-451187909
Yes I agree but I had to change it only on
- internals (runners, metrics sinks, metrics pusher)
- tests
Is manually setting options by the user though PipelineOptions supposed to
be supported ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 180765)
Time Spent: 50m (was: 40m)
> Remove Metrics Sinks specific methods from PipelineOptions
> ----------------------------------------------------------
>
> Key: BEAM-6030
> URL: https://issues.apache.org/jira/browse/BEAM-6030
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: 2.8.0
> Reporter: Federico Mendez
> Assignee: Etienne Chauchot
> Priority: Critical
> Time Spent: 50m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-4553 introduced methods in the
> base PipelineOptions interfaces that are specific to Graphite
> get/setMetricsGraphiteHost and get/setMetricsGraphitePort.
> I'd suggest to those elements should be moved to a
> PipelineOptionsGraphiteMetricsSink interfaces to avoid having technology
> specific methods in base classes/interfaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
