[
https://issues.apache.org/jira/browse/BEAM-4030?focusedWorklogId=180840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180840
]
ASF GitHub Bot logged work on BEAM-4030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/19 19:30
Start Date: 03/Jan/19 19:30
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #7405: [BEAM-4030] Add
compact attribute to combiners
URL: https://github.com/apache/beam/pull/7405
Add compact attribute to combiners and update some labels.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 180840)
Time Spent: 10m
Remaining Estimate: 0h
> Add CombineFn.compact, similar to Java
> --------------------------------------
>
> Key: BEAM-4030
> URL: https://issues.apache.org/jira/browse/BEAM-4030
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some CombineFns buffer elements in their add_inputs because a combining
> operation cost can be effectively amortized across many elements. However,
> this introduces the extra (possibly higher) cost of potentially serializing
> more expensive buffers through shuffle. We should add a
> CombineFn.compact(self, accumulator) method (defaulting to the identity)
> similar to what the Java SDK provides which is called when flushing an
> element from the PGBKCV table.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
