[
https://issues.apache.org/jira/browse/BEAM-6228?focusedWorklogId=181289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181289
]
ASF GitHub Bot logged work on BEAM-6228:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/19 19:44
Start Date: 04/Jan/19 19:44
Worklog Time Spent: 10m
Work Description: swegner commented on issue #7312: [BEAM-6228] Ensure
the website can build without a git repository
URL: https://github.com/apache/beam/pull/7312#issuecomment-451548234
I've added the (brief) context thread to this PR description:
https://lists.apache.org/thread.html/dc816a5f8c82dd4d19e82666209305ec67d46440fe8edba4534f9b63@%3Cdev.beam.apache.org%3E
/cc @kennknowles
> I'm confused as to when you'd need to build from a source archive. Since
the setup doesn't let you use grgit, you can't actually push the build
anywhere, right?
In general I agree; there's no practical reason why you should need to build
the website from the source archive. However, my understanding which leads to
this being desirable:
a) In Apache, "source releases" are the only real releases; released
binaries are a convenience. So it should be possible to build artifacts from
the source release.
b) Our website is included in the source release and the overall Gradle
build. So it shouldn't prevent the rest of the build from succeeding.
An alternative solution might be to separate the website out from the source
release, or disable itself from the build when a git environment isn't found.
However, I do see some value in being able to build / stage the website from
source archive, i.e. to get a snapshot of the website as it existed at a
point-in-time. And the delta to support it was small.
> Also, could this step be added to the release documentation? I couldn't
find any mentions of `stageWebsite` or `commitWebsite`.
There's no requirement to validate the website explicitly during the build.
The website will be built/tested when doing a top-level `./gradlew build`. I
don't know whether this is what @kennknowles did.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 181289)
Time Spent: 50m (was: 40m)
> Website build from source release fails due to git dependency
> -------------------------------------------------------------
>
> Key: BEAM-6228
> URL: https://issues.apache.org/jira/browse/BEAM-6228
> Project: Beam
> Issue Type: New Feature
> Components: website
> Reporter: Scott Wegner
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The website build assumes a git environment, and will fail if built outside
> of git. As a result, we cannot build the website from the source release.
> [~kenn] noticed this during 2.9.0 release validation. See:
> https://lists.apache.org/thread.html/dc816a5f8c82dd4d19e82666209305ec67d46440fe8edba4534f9b63@%3Cdev.beam.apache.org%3E
> {code}
> > Configure project :beam-website
> No git repository found for :beam-website. Accessing grgit will cause an NPE.
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'website/build.gradle' line: 143
> * What went wrong:
> A problem occurred evaluating project ':beam-website'.
> > Cannot get property 'branch' on null object
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
