[ 
https://issues.apache.org/jira/browse/BEAM-6248?focusedWorklogId=181793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181793
 ]

ASF GitHub Bot logged work on BEAM-6248:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jan/19 14:31
            Start Date: 07/Jan/19 14:31
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #7300: [BEAM-6248] Add 
Flink v1.7 build target to Flink Runner 
URL: https://github.com/apache/beam/pull/7300#discussion_r245671479
 
 

 ##########
 File path: 
runners/flink/src/test/java/org/apache/beam/runners/flink/PortableStateExecutionTest.java
 ##########
 @@ -86,6 +86,7 @@ public void testExecution() throws Exception {
     options.setRunner(CrashingRunner.class);
     options.as(FlinkPipelineOptions.class).setFlinkMaster("[local]");
     options.as(FlinkPipelineOptions.class).setStreaming(isStreaming);
+    options.as(FlinkPipelineOptions.class).setParallelism(4);
 
 Review comment:
   Our current test setup wastes quite a few resources because it uses the 
number of available cores in most places. Will do a follow-up to fix that.
   
   >I would prefer 2 if the intention is to exercise parallel execution path, 1 
otherwise.
   
   Do you think a slightly higher parallelism would increase the chance of 
exposing bugs? For example, the key distribution might be more skewed with a 
higher parallelism.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 181793)
    Time Spent: 3h 50m  (was: 3h 40m)

> Add Flink 1.7.x build target to Flink Runner
> --------------------------------------------
>
>                 Key: BEAM-6248
>                 URL: https://issues.apache.org/jira/browse/BEAM-6248
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>             Fix For: 2.10.0
>
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> With BEAM-5419 we can add a Flink 1.7.x build target.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to