[
https://issues.apache.org/jira/browse/BEAM-10135?focusedWorklogId=449183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449183
]
ASF GitHub Bot logged work on BEAM-10135:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/20 11:42
Start Date: 22/Jun/20 11:42
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r443498168
##########
File path: sdks/python/apache_beam/io/external/jdbc.py
##########
@@ -0,0 +1,116 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+ PTransforms for supporting Jdbc in Python pipelines. These transforms do not
+ run a Jdbc client in Python. Instead, they expand to ExternalTransforms
+ which the Expansion Service resolves to the Java SDK's JdbcIO.
+
+ Note: To use these transforms, you need to start a Java Expansion Service.
+ Please refer to the portability documentation on how to do that. Flink Users
+ can use the built-in Expansion Service of the Flink Runner's Job Server. The
+ expansion service address has to be provided when instantiating the
+ transforms.
Review comment:
If I move it to Write transform, then it should also be in Read
transform which is the next step of this task so the information would be
duplicated.
It is already done in the same way in kafka.py and generate_sequence.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 449183)
Time Spent: 2h 40m (was: 2.5h)
> Add cross-language wrapper for Java's JdbcIO Read
> -------------------------------------------------
>
> Key: BEAM-10135
> URL: https://issues.apache.org/jira/browse/BEAM-10135
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Read
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
